Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update federation flag when fetching server config [WPB-14728] (#3143) #3189

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Dec 19, 2024

  • fix: update federation flag when updating api version

  • fix test

  • remove not needed comment

  • fix jvm tests

(cherry picked from commit 790b885)


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

federation flag was not updated when updating api version

Solutions

update it

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…3143)

* fix: update federation flag when updating api version

* fix test

* remove not needed comment

* fix jvm tests

(cherry picked from commit 790b885)
@echoes-hq echoes-hq bot added the echoes: unplanned/incident Work items addressing critical product defects that require immediate action, such as bugs, platf... label Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Test Results

3 074 tests   2 966 ✔️  2m 59s ⏱️
   526 suites     108 💤
   526 files           0

Results for commit 43721f5.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 19, 2024

Datadog Report

Branch report: fix/update-federation-flag-when-fetching-api-version
Commit report: dcbbdc0
Test service: kalium-jvm

✅ 0 Failed, 2966 Passed, 108 Skipped, 24.88s Total Time

Copy link

sonarqubecloud bot commented Jan 7, 2025

@MohamadJaara MohamadJaara enabled auto-merge (squash) January 7, 2025 10:32
@MohamadJaara MohamadJaara merged commit f8e4329 into release/android-cycle-4.6 Jan 7, 2025
19 of 20 checks passed
@MohamadJaara MohamadJaara deleted the fix/update-federation-flag-when-fetching-api-version branch January 7, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned/incident Work items addressing critical product defects that require immediate action, such as bugs, platf... 🚨 Potential breaking changes 👕 size: M type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants