Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for old format parser in capabilities (WPB-12022) 🍒 #3174

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 13, 2024

TaskWPB-12022 [Android] API V7 related client ticket

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

V7 API changes in capabilities, add missing test to cover the retrocompat case.
Covering alternative (not modifying the serializer) for #3151 with working tests

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor Author

github-actions bot commented Dec 13, 2024

Test Results

3 341 tests  +1   3 234 ✅ +1   5m 46s ⏱️ +24s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit 6321ec3. ± Comparison against base commit 203d128.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

@yamilmedina yamilmedina added this pull request to the merge queue Dec 13, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.11%. Comparing base (203d128) to head (6321ec3).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3174   +/-   ##
========================================
  Coverage    54.11%   54.11%           
========================================
  Files         1252     1252           
  Lines        36519    36519           
  Branches      3699     3699           
========================================
  Hits         19764    19764           
+ Misses       15331    15330    -1     
- Partials      1424     1425    +1     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 203d128...6321ec3. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: test/capabilities-retrocompat-cherry-pick
Commit report: 320a162
Test service: kalium-jvm

✅ 0 Failed, 3234 Passed, 107 Skipped, 1m 9.2s Total Time

Merged via the queue into develop with commit 5396afa Dec 13, 2024
23 checks passed
@yamilmedina yamilmedina deleted the test/capabilities-retrocompat-cherry-pick branch December 13, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants