-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove self user creator [WPB-11559] #3118
Conversation
Test Results3 329 tests - 1 3 222 ✅ - 1 5m 1s ⏱️ -12s Results for commit 4520416. ± Comparison against base commit a02f920. This pull request removes 1 test.
♻️ This comment has been updated with latest results. |
Bencher Report
Click to view all benchmark results
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3118 +/- ##
===========================================
- Coverage 54.21% 54.21% -0.01%
===========================================
Files 1250 1250
Lines 36328 36323 -5
Branches 3658 3657 -1
===========================================
- Hits 19697 19693 -4
Misses 15218 15218
+ Partials 1413 1412 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3222 Passed, 107 Skipped, 35.96s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also remove it from the view where it is created
should I also remove it from db? |
if it is not used anywhere else then yes |
Quality Gate passedIssues Measures |
https://wearezeta.atlassian.net/browse/WPB-11559
What's new in this PR?
Issues
We dont need the selfUserCreator anymore as the constraints on deleting group have changes, and now we need to belong to the same team.
Merge after
Merge only after this is merged wireapp/wire-android#3652
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.