Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove self user creator [WPB-11559] #3118

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Nov 21, 2024

StoryWPB-11559 [Android] Delete a group as admin

https://wearezeta.atlassian.net/browse/WPB-11559

What's new in this PR?

Issues

We dont need the selfUserCreator anymore as the constraints on deleting group have changes, and now we need to belong to the same team.

Merge after

Merge only after this is merged wireapp/wire-android#3652


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Test Results

3 329 tests   - 1   3 222 ✅  - 1   5m 1s ⏱️ -12s
  571 suites ±0     107 💤 ±0 
  571 files   ±0       0 ❌ ±0 

Results for commit 4520416. ± Comparison against base commit a02f920.

This pull request removes 1 test.
com.wire.kalium.persistence.dao.ConversationDAOTest ‑ givenSelfUserIsCreatorOfConversation_whenGettingConversationDetails_itReturnsCorrectDetails[jvm]

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 21, 2024

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.21%. Comparing base (a02f920) to head (4520416).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3118      +/-   ##
===========================================
- Coverage    54.21%   54.21%   -0.01%     
===========================================
  Files         1250     1250              
  Lines        36328    36323       -5     
  Branches      3658     3657       -1     
===========================================
- Hits         19697    19693       -4     
  Misses       15218    15218              
+ Partials      1413     1412       -1     
Files with missing lines Coverage Δ
...ire/kalium/logic/data/conversation/Conversation.kt 0.00% <ø> (ø)
...lium/logic/data/conversation/ConversationMapper.kt 58.15% <ø> (+0.12%) ⬆️
...onversation/ConversationDetailsWithEventsMapper.kt 92.55% <ø> (-0.08%) ⬇️
...persistence/dao/conversation/ConversationMapper.kt 97.87% <ø> (-0.03%) ⬇️
...istence/dao/conversation/ConversationViewEntity.kt 97.87% <ø> (-0.05%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a02f920...4520416. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 21, 2024

Datadog Report

Branch report: chore/remove-self-user-creator
Commit report: a69f9a4
Test service: kalium-jvm

✅ 0 Failed, 3222 Passed, 107 Skipped, 35.96s Total Time

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also remove it from the view where it is created

@m-zagorski
Copy link
Contributor Author

please also remove it from the view where it is created

should I also remove it from db?

@MohamadJaara
Copy link
Member

please also remove it from the view where it is created

should I also remove it from db?

if it is not used anywhere else then yes

@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Nov 28, 2024
@MohamadJaara MohamadJaara added this pull request to the merge queue Dec 2, 2024
Merged via the queue into develop with commit ee39af7 Dec 2, 2024
22 checks passed
@MohamadJaara MohamadJaara deleted the chore/remove-self-user-creator branch December 2, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 🚨 Potential breaking changes 👕 size: M type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants