fix: Migration message not shown in 1:1 conversations (WPB-11194) #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: unplanned
ohassine
requested review from
a team,
typfel,
alexandreferris,
mchenani,
Garzas and
saleniuk
and removed request for
a team
github-actions
bot
added
🚨 Potential breaking changes
👕 size: S
type: bug / fix 🐞
labels
|
|
Bencher Report| Branch | Migration-message-not-shown-in-11-conversations |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 715,802.76 |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 698,185,794.77 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 951,522,296.39 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 21,699,622.70 |
Datadog ReportBranch report: ✅ 0 Failed, 3101 Passed, 107 Skipped, 12.02s Total Time |
|
Should we backport this to |
vitorhugods
approved these changes
Sep 26, 2024
yamilmedina
approved these changes
Sep 26, 2024
ohassine
deleted the
Migration-message-not-shown-in-11-conversations
branch
MohamadJaara
pushed a commit
that referenced
this pull request
Oct 18, 2024
yamilmedina
pushed a commit
that referenced
this pull request
Jan 9, 2025
7 tasks
yamilmedina
added a commit
that referenced
this pull request
Jan 9, 2025
…WPB-11194) (#3221) * fix: fallback to proteus if conversation already present but MLS is default (WPB-15191) (#3200) * fix: fallback to proteus if conversation already present and no common protocol * fix: test coverage * fix: test coverage * fix: Migration message not shown in 1:1 conversations (#3042) * fix: update common protocol resolution (#3208) * feat: detekt --------- Co-authored-by: Oussama Hassine <[email protected]>
7 tasks
Garzas
added a commit
that referenced
this pull request
Jan 10, 2025
* fix: fallback to proteus if conversation already present but MLS is default (WPB-15191) (#3200) * fix: fallback to proteus if conversation already present and no common protocol * fix: test coverage * fix: test coverage * fix: Migration message not shown in 1:1 conversations (#3042) * fix: update common protocol resolution (#3208) * fix: mls client init [WPB-15022] (#3178) * fix: secure mls client creation with is mls enabled * fix: dont persist mls conversations when mls is disabled * review improvements * fix: persist mls conversation when mls disabled (#3205) --------- Co-authored-by: Yamil Medina <[email protected]> Co-authored-by: Oussama Hassine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
We don't show any system messages after dowing the migration from Proteus to MLS in 1:1 conversations
Causes (Optional)
Not implemented
Solutions
Call
insertProtocolChangedSystemMessageafter finishing the migration for 1:1 conversationsNeeds releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.