feat: check Certificate Revocation List for current client (WPB-3243) #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…#2498) * feat: check CRL for current client * chore: resolve conflicts * chore: unused imports * chore: unused imports * fix: url format * chore: cleanup * chore: cleanup * chore: check if E2ei is enabled before running CheckRevocationListForCurrentClientUseCase * chore: cleanup
github-actions
bot
added
the
cherry-pick
ohassine
approved these changes
Mar 1, 2024
Test Results2 760 tests - 190 2 675 ✔️ - 155 27s ⏱️ - 2m 28s Results for commit 834cc45. ± Comparison against base commit 5c7e158. This pull request removes 2950 and adds 2760 tests. Note that renamed tests count towards both.This pull request removes 120 skipped tests and adds 85 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
alexandreferris
approved these changes
Mar 1, 2024
ohassine
approved these changes
Mar 1, 2024
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jschumacher-wire
pushed a commit
that referenced
this pull request
Mar 6, 2024
…#2570) * feat: check Certificate Revocation List for current client (WPB-3243) (#2498) * feat: check CRL for current client * chore: resolve conflicts * chore: unused imports * chore: unused imports * fix: url format * chore: cleanup * chore: cleanup * chore: check if E2ei is enabled before running CheckRevocationListForCurrentClientUseCase * chore: cleanup * chore: empty commit --------- Co-authored-by: Oussama Hassine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Checking CRL for current client is missing.
Solutions
I Created a new use case for it that will be called once to check CRL and store the url with expiration in DB.
And then it's up to to check constantly CRLs.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References