Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monkeys): Write CC version in logs and allow to skip warmup [WPB-6784] #2529

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

augustocdias
Copy link

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Adds the possibility to skip the warmup (which can be useful when running with preset users) and writes the CC version in the logs


References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Feb 21, 2024

Test Results

2 916 tests  ±0   2 794 ✔️ ±0   2m 27s ⏱️ +8s
   511 suites ±0      122 💤 ±0 
   511 files   ±0          0 ±0 

Results for commit 5d178e5. ± Comparison against base commit 5e527d3.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (133ae82) 58.37% compared to head (5d178e5) 58.37%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2529      +/-   ##
=============================================
- Coverage      58.37%   58.37%   -0.01%     
  Complexity        21       21              
=============================================
  Files           1172     1173       +1     
  Lines          45353    45376      +23     
  Branches        4292     4294       +2     
=============================================
+ Hits           26474    26486      +12     
- Misses         16954    16965      +11     
  Partials        1925     1925              

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 133ae82...5d178e5. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/monkeys/skip-warmup
Commit report: 78a0210
Test service: kalium-jvm

✅ 0 Failed, 2794 Passed, 122 Skipped, 8m 48s Wall Time

@MohamadJaara MohamadJaara added this pull request to the merge queue Feb 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2024
@MohamadJaara MohamadJaara added this pull request to the merge queue Feb 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2024
@augustocdias augustocdias added this pull request to the merge queue Feb 22, 2024
Merged via the queue into develop with commit f3f33c3 Feb 22, 2024
17 checks passed
@augustocdias augustocdias deleted the feat/monkeys/skip-warmup branch February 22, 2024 07:49
jschumacher-wire pushed a commit that referenced this pull request Mar 6, 2024
…-6784] (#2529)

* feat(monkeys): Write CC version in logs and allow to skip warmup [WPB-6784]

* close stream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants