fix: e2ei endpoint is called even when the feature is disabled #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: M
labels
MohamadJaara
commented
Feb 16, 2024
| @@ -22,7 +22,7 @@ import kotlinx.datetime.Instant | |||
|
|
|||
| data class E2EISettings( | |||
| val isRequired: Boolean, | |||
| val discoverUrl: String, | |||
| val discoverUrl: String?, | |||
There was a problem hiding this comment.
the url can be null even when the feature is enabled 😢
MohamadJaara
commented
Feb 16, 2024
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| override fun discoveryUrl(): Either<CoreFailure, String> = |
There was a problem hiding this comment.
the idea of this function is to have a central place where the errors with e2ei url are caught
MohamadJaara
commented
Feb 16, 2024
| @@ -203,7 +203,7 @@ data class TeamSettingsSelfDeletionStatusEntity( | |||
| @Serializable | |||
| data class E2EISettingsEntity( | |||
| @SerialName("status") val status: Boolean, | |||
| @SerialName("discoverUrl") val discoverUrl: String, | |||
| @SerialName("discoverUrl") val discoverUrl: String?, | |||
There was a problem hiding this comment.
according to swagger this URL can be null
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2508 +/- ##
====================================================
Coverage ? 58.39%
Complexity ? 21
====================================================
Files ? 1171
Lines ? 45336
Branches ? 4292
====================================================
Hits ? 26472
Misses ? 16940
Partials ? 1924
Continue to review full report in Codecov by Sentry.
|
MohamadJaara
requested review from
mchenani,
borichellow and
ohassine
and removed request for
mchenani and
borichellow
MohamadJaara
commented
Feb 19, 2024
network/src/commonMain/kotlin/com/wire/kalium/network/api/base/unbound/acme/ACMEApi.kt
Outdated
Show resolved
Hide resolved
mchenani
approved these changes
Feb 19, 2024
borichellow
approved these changes
Feb 19, 2024
MohamadJaara
deleted the
fix/e2ei-url-is-mapped-to-empty-string-when-missing
branch
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
* fix: e2ei endpoint is called even when the feature is disabled * detekt * revert unwanted change * revert unwanted change
8 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
#2511) * fix: e2ei endpoint is called even when the feature is disabled * detekt * revert unwanted change * revert unwanted change Co-authored-by: Mohamad Jaara <[email protected]> Co-authored-by: Mojtaba Chenani <[email protected]>
jschumacher-wire
pushed a commit
that referenced
this pull request
Mar 6, 2024
#2511) * fix: e2ei endpoint is called even when the feature is disabled * detekt * revert unwanted change * revert unwanted change Co-authored-by: Mohamad Jaara <[email protected]> Co-authored-by: Mojtaba Chenani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
it can happen that e2ei endpoint is called with empty URL when it is disabled
Solutions
small refactor to make sure it cann't be called when it is not enabled
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.