Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2ei): use refresh token for IDP authorisation (WPB-5880) #2327

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

mchenani
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

With oAuth refresh token, we can get a new id token without forcing the user to login again on the idp, in this PR all the requirements on kalium are considered.

Dependencies (Optional)

Needs to be merged with AR

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Dec 21, 2023

Test Results

2 787 tests  ±0   2 683 ✔️ ±0   2m 27s ⏱️ -12s
   488 suites ±0      104 💤 ±0 
   488 files   ±0          0 ±0 

Results for commit e5bb30b. ± Comparison against base commit e07f991.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 21, 2023

Datadog Report

All test runs 7b0ce1b 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1970 55 4m 17s Link
kalium-jvm 0 0 0 2683 104 8m 37.04s Link

@mchenani mchenani changed the title feat(e2ei): use refresh token for idp authorisation (WPB-5880) feat(e2ei): use refresh token for IDP authorisation (WPB-5880) Dec 21, 2023
@mchenani mchenani enabled auto-merge December 21, 2023 15:57
@mchenani mchenani added this pull request to the merge queue Dec 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2023
@mchenani mchenani added this pull request to the merge queue Dec 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2023
@mchenani mchenani added this pull request to the merge queue Dec 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2023
@mchenani mchenani added this pull request to the merge queue Dec 21, 2023
Merged via the queue into develop with commit d911835 Dec 21, 2023
17 checks passed
@mchenani mchenani deleted the feat/e2ei/update-certificate-with-refresh-token branch December 21, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants