Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update all users when getting their data [AR-5057] #2200

Merged

Conversation

vitorhugods
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Users in big teams or not in teams at all are not receiving profile updates of other users.

Causes

Big teams and non-team members do not propagate user.update events to all contacts.

Solutions

This commit removes distinction between federated and non-federated users in UserRepository when getting known users.

All users are now treated in the same manner when getting them from the database. This implies that their data will be refreshed from the API regardless of the user type.

Testing

Adjustments have been made to the UserRepositoryTest to reflect this change in behavior.

Test Coverage

  • I have added automated test to this contribution

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

This commit removes distinction between federated and non-federated users in UserRepository when getting known users. All users are now treated in the same manner when getting them from the database. This implies that their data will be refreshed from the API regardless of the user type. Adjustments have been made to the UserRepositoryTest to reflect this change in behavior.
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Unit Test Results

       6 files         6 suites   7m 54s ⏱️
2 261 tests 2 243 ✔️ 18 💤 0

Results for commit bce6394.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/update-all-users-when-getting-their-data
Commit report: a0c76be

kalium-jvm: 0 Failed, 0 New Flaky, 2238 Passed, 51 Skipped, 5m 49.01s Wall Time

@vitorhugods vitorhugods merged commit 33a635a into release/candidate Nov 7, 2023
9 of 11 checks passed
@vitorhugods vitorhugods deleted the fix/update-all-users-when-getting-their-data branch November 7, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants