Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failure to parse lack of supported protocols #2167

Merged

Conversation

vitorhugods
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Exception during parsing of SupportedProtocol:

java.lang.IllegalArgumentException: No enum constant com.wire.kalium.persistence.dao.SupportedProtocolEntity.

Causes

We're not considering the possibility of empty string ""

Solutions

Return emptySet() when the string is empty. This means that the client has not set supported protocols for a user yet.

Testing

Test Coverage

  • I have added automated test to this contribution

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Unit Test Results

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit 8c64831.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 24, 2023

Datadog Report

All test runs ab63661 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2136 66 7m 20.1s Link
kalium-jvm 0 0 0 2456 104 13m 24s Link

@codecov-commenter
Copy link

Codecov Report

Merging #2167 (3c9f93c) into develop (872981a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             develop    #2167   +/-   ##
==========================================
  Coverage      57.88%   57.89%           
  Complexity        21       21           
==========================================
  Files           1059     1059           
  Lines          40190    40192    +2     
  Branches        3722     3722           
==========================================
+ Hits           23265    23268    +3     
  Misses         15314    15314           
+ Partials        1611     1610    -1     
Files Coverage Δ
...persistence/adapter/SupportedProtocolSetAdapter.kt 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 872981a...3c9f93c. Read the comment docs.

@vitorhugods vitorhugods added this pull request to the merge queue Oct 24, 2023
@vitorhugods vitorhugods removed this pull request from the merge queue due to a manual request Oct 24, 2023
@vitorhugods vitorhugods merged commit 50fa995 into develop Oct 24, 2023
@vitorhugods vitorhugods deleted the fix/mls/failure-to-parse-lack-of-supported-protocols branch October 24, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants