Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

chore: use JDK 17 #38

Merged
merged 5 commits into from
Jul 24, 2023
Merged

chore: use JDK 17 #38

merged 5 commits into from
Jul 24, 2023

Conversation

vitorhugods
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The created docker images have JDK 11 inside. Making it impossible to run newer software, considering that JDK 17 is the most recent LTS version.

Solutions

Upgrade the docker images to JDK 17, and use JDK 17 on CI to match.

Had to upgrade jmx_exporter to 0.19.0 in order to support building it with newer JDK as well.

Note
This PR also upgrades the version to 1.4.0 so current users of the 1.3.0 docker images can still use JDK 11 without issues.

Testing

Built it locally and it's working. The docker image is built successfully with the correct artifacts and JDK 17:

image

Test Coverage

N/A

How to Test

  • docker build --file Dockerfile --target cryptobox --tag wirebot/cryptobox ../ and run Java applications using Cryptobox as a dependency

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄

@dkovacevic dkovacevic merged commit 25c65fd into wireapp:master Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants