This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
The created docker images have JDK 11 inside. Making it impossible to run newer software, considering that JDK 17 is the most recent LTS version.
Solutions
Upgrade the docker images to JDK 17, and use JDK 17 on CI to match.
Had to upgrade jmx_exporter to 0.19.0 in order to support building it with newer JDK as well.
Testing
Built it locally and it's working. The docker image is built successfully with the correct artifacts and JDK 17:
Test Coverage
N/A
How to Test
docker build --file Dockerfile --target cryptobox --tag wirebot/cryptobox ../
and run Java applications using Cryptobox as a dependencyPR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.