Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] 1.2 Replace plugin eager loading #580

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

jaxwilko
Copy link
Member

This PR moves class loader namespace aliasing into the replacement logic. This is required to ensure that plugins that are marked as invalid to replace others will not have their namespaces aliases.

@LukeTowers LukeTowers added Status: Completed maintenance PRs that fix bugs, are translation changes or make only minor changes labels Jun 20, 2022
@LukeTowers LukeTowers added this to the v1.2.0 milestone Jun 20, 2022
@LukeTowers LukeTowers merged commit 225313f into wip/1.2 Jun 20, 2022
@LukeTowers LukeTowers deleted the fix/1.2-replace-plugin-eager-loading branch June 20, 2022 21:05
LukeTowers added a commit that referenced this pull request Jun 29, 2022
* wip/1.2: (21 commits)
  Added fix to ensure correct normalization and return (#588)
  Outputs time respecting backend preferences (#572)
  Bump minimum Laravel version to 9.1
  Fix site relative partial paths failing in 1.2 (#587)
  Switch back to using Laravel CacheServiceProvider
  Rebuild Snowboard agian
  Revert "Rebuild Snowboard"
  Rebuild Snowboard
  Allow a string selector for the form in a request
  Allow a string selector for the form in a request
  Use correct line breaks for Windows tests
  Backport ViewMaker tests from 1.2 branch
  Add additional testMakePartial cases to ViewMaker unit tests (#586)
  Added replaced plugins to the normalize map to ensure classloader namespace aliasing detects replacements (#585)
  Split tests into relevant module folders
  [FIX] Fix plugin flags not loading from cache correctly (#582)
  farsi spelling correction (#579)
  Moved plugin replacement namespace aliasing into register replacement method (#580)
  fix typo
  Add Winter 1.2 as version option in bug report
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants