-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Font Awesome 4 to 6 #551
Conversation
@bennothommo are you also able to update the UI Icon docs in this PR? Should we like to the FontAwesome 6 site instead of hosting it all ourselves? |
@LukeTowers I was thinking that, but we do use a different class structure for the icons. They provide a JSON schema of all icons so it may not be too difficult to create a component that can generate the list in our docs. |
16k icons is a lot. I'd be fine with just including instructions for how to change their class names to ours and then linking to their docs. They have a custom algolia integration in order to search all of the icons, I don't really want to go down that road on our end too. |
We will load icons independently in another file so it can be cached independently.
Also separated the global base styles for icons with the actual icon list, so we can limit the icons loaded (ie. for the standard exception / error views)
@bennothommo there is no
|
@WebVPF sorry, it appeared I hadn't included the brand icons in the compiled icon CSS. They're included now. :) |
Replaces #445 and #447.
This PR upgrades Font Awesome 4 to Font Awesome 6, bringing the number of available icons from 675 to 1748, as mentioned in the above PRs. It has been implemented using Font Awesome's LESS files, but keeps everything backwards compatible by shimming the old icon variables and ensuring the old classes point to the correct font weighting and icon.
This does increase the Backend assets from 4.84MB to 5.06MB (an increase of ~220kb) uncompressed - I haven't tested this using GZIP but would estimate it would equate to around 50-60kb, so shouldn't be too much of a hit.