Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent error if accessing undefined $resizer variable #502

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Prevent error if accessing undefined $resizer variable #502

merged 1 commit into from
Mar 21, 2022

Conversation

mjauvin
Copy link
Member

@mjauvin mjauvin commented Mar 20, 2022

When exception happens within the ImageResizer::fromIdentifier() call, the $resizer variable is not defined within the catch() block

@mjauvin mjauvin added maintenance PRs that fix bugs, are translation changes or make only minor changes needs review Issues/PRs that require a review from a maintainer labels Mar 20, 2022
@mjauvin mjauvin added this to the v1.2.0 milestone Mar 20, 2022
@mjauvin mjauvin self-assigned this Mar 20, 2022
@bennothommo bennothommo added Status: Completed and removed needs review Issues/PRs that require a review from a maintainer labels Mar 21, 2022
@bennothommo bennothommo changed the title prevent error if accessing undefined $resizer variable Prevent error if accessing undefined $resizer variable Mar 21, 2022
@bennothommo bennothommo merged commit e433aa3 into wintercms:wip/1.2 Mar 21, 2022
@mjauvin mjauvin deleted the fix-undefined-resizer-var branch March 21, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mjauvin mjauvin

Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mjauvin @bennothommo