Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isActive for CMS page with "/" as URL #479

Merged
merged 7 commits into from
Mar 18, 2022
Merged

Fix isActive for CMS page with "/" as URL #479

merged 7 commits into from
Mar 18, 2022

Conversation

mjauvin
Copy link
Member

@mjauvin mjauvin commented Mar 2, 2022 •
edited by gitpod-io bot
Loading

Fix #478

@mjauvin mjauvin added Status: Completed maintenance PRs that fix bugs, are translation changes or make only minor changes low priority Issues that are backlogged for when things are less busy labels Mar 2, 2022
@mjauvin
Copy link
Member Author

mjauvin commented Mar 3, 2022

Added unit test @LukeTowers

@mjauvin mjauvin added this to the v1.2.0 milestone Mar 3, 2022
@mjauvin mjauvin self-assigned this Mar 3, 2022
@bennothommo bennothommo merged commit 3cf4b5a into wintercms:wip/1.2 Mar 18, 2022
@mjauvin mjauvin deleted the fix-is-active branch March 18, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeTowers LukeTowers LukeTowers left review comments

@bennothommo bennothommo bennothommo left review comments

Assignees

@mjauvin mjauvin

Labels
low priority Issues that are backlogged for when things are less busy maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mjauvin @LukeTowers @bennothommo