-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table widget improvements #1285
Draft
bennothommo
wants to merge
7
commits into
develop
Choose a base branch
from
wip/table-widget-improvements
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Style readonly columns with grey background to clearly indicate read-only state - Prevent editors from being created for all column types if readonly (previously, only string columns would be rendered read-only) - Allow tab and arrow navigation for readonly columns
@bennothommo is this ready for review? |
@LukeTowers everything except for the Inspector column type. I could strip that out and do that as another PR. |
@bennothommo let's do that then. Would like to release 1.2.8 in the next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readonly
attribute, this is not ideal because it can be easily changed)readOnly
option case-insensitivesearching
option to show search box even ifadding
anddeleting
buttons are disabledIn progress
inspector
column type for data tables - allowing support for complex values for individual table records (ie. an object).