Fix type issues with Typescript 4 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The catch blocks have some "new" syntax we need to adhere to: microsoft/TypeScript#36775 As of Feathers 4, the request and response body are actually of type any, but we have to specify that explicitly. We can probably get rid of this `// @ts-ignore` now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The catch blocks have some "new" syntax we need to adhere to: microsoft/TypeScript#36775
As of Feathers 4, the request and response body are actually of type any, but we have to specify that explicitly.
We can probably get rid of this
// @ts-ignorenow.I also went ahead and fixed some other type issues with strategy.ts
Type 'SamlStrategy' has no properties in common with type AuthenticationBase.https://stackoverflow.com/questions/46449237/type-x-has-no-properties-in-common-with-type-y