Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the logger (this) in the fourth argument in the rewriters function #626

Closed

Conversation

christophehurpeau
Copy link
Contributor

No description provided.

@christophehurpeau christophehurpeau changed the title Add the logger (this} in the fourth argument in the rewriters function Add the logger (this) in the fourth argument in the rewriters function May 10, 2015
@pose
Copy link
Member

pose commented May 12, 2015

@christophehurpeau Thanks for your contribution. What use case did you have in mind? Filters and Reformatters will be dropped in next major so I think if there's a workaround for this right now it might be better to wait. /cc: @indexzero @jcrugzz

@christophehurpeau
Copy link
Contributor Author

I'm trying to add a label in the logger and add it to all messages, no matter the transport.
You can see it here : https://github.com/christophehurpeau/springbokjs-logger/blob/4.0/src/index.js#L31

@indexzero
Copy link
Member

This is something we could consider before 2.0.0

@indexzero indexzero added the Feature Request Request for new functionality to support use cases not already covered label May 19, 2015
@indexzero
Copy link
Member

This has been cherry-picked and will land in [email protected] later today.

@indexzero indexzero closed this Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Request for new functionality to support use cases not already covered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants