err can be a string

[gdw2]

See #204

[jcrugzz]

@gdw2 could you show the case where this can be a string? this just seems horribly wrong if an error was somehow stringified.

[gdw2]

See the issue I linked (#204). I'll need to track down exactly what's producing it since it isn't outputting a stack trace.

[gdw2]

I looked into it a little more and it appears that err isn't a string, but instead is an array of two errors: [err, err]. It's bubbling up from the node.js:process._processFatal() method. Does this seem more acceptable, and if so, how do we handle it?

I'm still not sure from where it's originating. I have the debugger stopping at a breakpoint, but nothing traces back further than the _processFatal() method. I wonder if this is any indicator that its coming from native code?

[jcrugzz]

@gdw2 😖 that is just ridiculous. Are you running on the latest node by any chance? This seems like a silly bug in node core or something of the sort. While we can add some crufty code to handle this case, this should just not happen and should be fixed at the root cause.

[indexzero]

👍 this should go into the next [email protected] release.

[indexzero]

Cherry-picked as 122fb75