Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the stringify replacer option to the HTTP transport #2155

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Add the stringify replacer option to the HTTP transport #2155

merged 1 commit into from
Jun 23, 2022

Conversation

domiins
Copy link
Contributor

@domiins domiins commented Jun 23, 2022

Support custom stringify replacer when sending logs via HTTP transport.

Usage of the format.json with the custom replacer does not work with
HTTP transport since the message symlink (which is mutated) is not sent
in the request.

Work done:

  • Add the replacer property into the type of the HttpTransportOptions
  • Use the replacer from the options optionally in the jsonStringify of HTTP transport

@domiins
Add the replacer option to the HTTP transport
903e648 
Support custom stringify replacer when sending logs via HTTP transport.

Usage of the `format.json` with the custom replacer does not work with
HTTP transport since the message symlink (which is mutated) is not sent
in the request.
@wbt
Copy link
Contributor

wbt commented Jun 23, 2022

Thanks for your contribution!

@wbt wbt merged commit 355650e into winstonjs:master Jun 23, 2022
@domiins domiins deleted the feature/http-transfer-replacer branch June 23, 2022 14:42
@wbt
Copy link
Contributor

wbt commented Jun 23, 2022

Out in 3.8.0

@snyk-omar snyk-omar mentioned this pull request Oct 22, 2022
Open
@rish2497 rish2497 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@rish2497 rish2497 mentioned this pull request May 25, 2024
Open
@cvs-ops cvs-ops mentioned this pull request May 25, 2024
Open
@slatersnyk slatersnyk mentioned this pull request May 25, 2024
Open
@fanibahar fanibahar mentioned this pull request May 25, 2024
Open
@cooldev-200 cooldev-200 mentioned this pull request May 26, 2024
Open
@drwho725 drwho725 mentioned this pull request May 26, 2024
Closed
@hangrybear666 hangrybear666 mentioned this pull request Jun 5, 2024
Closed
@Haricthered Haricthered mentioned this pull request Jun 7, 2024
Open
@AndrewSnyk AndrewSnyk mentioned this pull request Jun 8, 2024
Open
@Mohit21GoJs Mohit21GoJs mentioned this pull request Jun 8, 2024
Open
@jessicazhanggg jessicazhanggg mentioned this pull request Jun 13, 2024
Open
@kleva-j kleva-j mentioned this pull request Jul 4, 2024
Merged
@stden stden mentioned this pull request Jul 7, 2024
Open
@debarghyab debarghyab mentioned this pull request Jul 11, 2024
Open
@drnachio drnachio mentioned this pull request Jul 12, 2024
Open
@rish2497 rish2497 mentioned this pull request Jul 13, 2024
Open
This was referenced Jul 13, 2024
Open
Open
@jbsnyk jbsnyk mentioned this pull request Jul 17, 2024
Open
@slatersnyk slatersnyk mentioned this pull request Jul 17, 2024
Open
@fanibahar fanibahar mentioned this pull request Jul 17, 2024
Open
@cooldev-200 cooldev-200 mentioned this pull request Jul 17, 2024
Open
@Elenore23 Elenore23 mentioned this pull request Jul 21, 2024
Open
@WontonSam WontonSam mentioned this pull request Jul 21, 2024
Open
@safiaminnn safiaminnn mentioned this pull request Jul 21, 2024
Open
@koishichito koishichito mentioned this pull request Jul 24, 2024
Open
@KobayashiMasaomi KobayashiMasaomi mentioned this pull request Jul 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domiins @wbt