Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #1817 #1819

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Fix issue #1817 #1819

merged 2 commits into from
Jun 23, 2020

Conversation

Pigotz
Copy link
Contributor

@Pigotz Pigotz commented Jun 23, 2020

This PR should fix this issue.

It should correct a typo for DefaultLevels type, previously DefaulLevels (missing t).

This is my first ever PR here so please, be kind to me 😄

DABH
DABH approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, my eyes missed the typo in the other PR. I think this looks good! Thanks again!

@DABH DABH merged commit bc6f681 into winstonjs:master Jun 23, 2020
@Mizumaki Mizumaki mentioned this pull request Jun 23, 2020
Merged
@Omrisnyk Omrisnyk mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DABH DABH DABH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createLogger breaking changes under patch release
2 participants
@Pigotz @DABH