Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing for Profile.start (was Date, should be Number) #1803

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Fix typing for Profile.start (was Date, should be Number) #1803

merged 1 commit into from
Jun 22, 2020

Conversation

cuzzlor
Copy link
Contributor

@cuzzlor cuzzlor commented Jun 2, 2020

Profile.start is actually a number:

https://github.com/winstonjs/winston/blob/master/lib/winston/profiler.js#L29

this.start = Date.now();

DABH
DABH approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DABH DABH merged commit 0e1c812 into winstonjs:master Jun 22, 2020
@Omrisnyk Omrisnyk mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DABH DABH DABH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuzzlor @DABH