Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add defaultMeta to Logger index.d.ts #1736

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Add defaultMeta to Logger index.d.ts #1736

merged 2 commits into from
Dec 2, 2019

Conversation

marikaner
Copy link
Contributor

The defaultMeta property was missing on the Logger interface

@marikaner
Copy link
Contributor Author

Dear winston team, it seems that the build is not breaking due to anything specific I did. ;)

DABH
DABH approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@DABH DABH merged commit 319abf1 into winstonjs:master Dec 2, 2019
Mizumaki pushed a commit to Mizumaki/winston that referenced this pull request Jun 11, 2020
@marikaner @DABH
Add defaultMeta to Logger index.d.ts (winstonjs#1736)
b866c5e 
* Update index.d.ts

* Update index.d.ts
@Omrisnyk Omrisnyk mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DABH DABH DABH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marikaner @DABH