-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue where winston removes transport on error (#1364) #1714
Conversation
This is a pretty big bug. Any chance we could get some love from the maintainers? |
Could we get this merged? |
Can someone with write access please merge this? :) |
It appears that the CI build failed because of a problem with the CI builder (it couldn't find
|
@yinzara Thank you for your responsiveness on this, however, it seems that now a valid test is failing. It doesn't seem like your code recent change caused it. I wish I knew why this were failing now. Do these tests pass locally for you?
|
I rebased on master. Let's see if that fixes it. |
@yinzara That seemed to fix it, however, now we are back to the problem with node not being found. Is there a maintainer that can help with this? @DABH would you know why we are getting this AppVeyor problems?
|
Hi folks, Thank you all for your work on this. Three comments--
Again, really appreciate all the thought and work put into this -- thank you and let me know your thoughts! |
|
@DABH Is there anything that prevents this from landing that we can perhaps help to address? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the replies, I think this makes sense to have this as the default behavior. Will go ahead and merge. Thanks again for your contribution!
…instonjs#1714) * Fix Issue where winston removes transport on error (winstonjs#1364) * Fix lint error to cause rebuild
#1364