Update .travis.yml to support Node.js 12 #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds Node.js 12 to the test matrix to make sure everything passes as expected. Node.js 11 is in maintenance and won't receive significant changes anymore, so I updated that as well (no test failures should be accepted).
|
Thanks @BridgeAR ! Actually, it looks like Node 6 is at long last not supported anymore. So can we also remove Node 6 from travis.yml and appveyor.yml (https://github.com/winstonjs/winston/blob/master/appveyor.yml), and add Node 12 to appveyor.yml too? Then this PR should be good to go (and should pass all CI checks). |
Mizumaki
pushed a commit
to Mizumaki/winston
that referenced
this pull request
Jun 11, 2020
* Update .travis.yml to support Node.js 12 This adds Node.js 12 to the test matrix to make sure everything passes as expected. Node.js 11 is in maintenance and won't receive significant changes anymore, so I updated that as well (no test failures should be accepted). * add n12 on appveyor, remove n6 from travis+appveyor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Node.js 12 to the test matrix to make sure everything passes as expected.
Node.js 11 is in maintenance and won't receive significant changes anymore, so I updated that as well (no test failures should be accepted).