common.log mutates an Error object passed as meta

[eddieajau]

In common.js there is the following code:

    output         = exports.clone(meta) || {};
    output.level   = options.level;
    output.message = options.message.stripColors;

But in exports.clone of the same file, you have:

exports.clone = function (obj) {
  //
  // We only need to clone reference types (Object)
  //
  if (obj instanceof Error) {
    return obj;
  }

If an error is passed as meta, the error message is unexpectedly mutated by the log call:

var error = new Error('this is the real error');
console.log(error.message); // -> this is the real error
logger.error('Func.name error', error);
console.log(error.message); // -> Func.name error

If you can let me know how you want that resolved, I'm happy to do the PR and tests.

[harriha]

This seems to be a duplicate of #610, and a (unmerged) fix is available in #703

[indexzero]

Yes. This is a duplicate of #610. Good catch @harriha