Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using gsub instead of sub #21

Merged
merged 1 commit into from
Jul 7, 2015
Merged

Using gsub instead of sub #21

merged 1 commit into from
Jul 7, 2015

Conversation

allenwq
Copy link
Contributor

@allenwq allenwq commented Jul 7, 2015

Currently if I have a Super::Awesome::AnimeController, the generated class name will be super/awesome_anime, which is not correct I think.

@JuanitoFatas JuanitoFatas merged commit 39c9a3b into winston:master Jul 7, 2015
JuanitoFatas added a commit that referenced this pull request Jul 7, 2015
@JuanitoFatas
Add #21 to CHANGELOG
cc8e918 
Closes #21
@JuanitoFatas
Copy link
Collaborator

Thanks for your contribution. Released v3.3.3, let me know if any problems.

@allenwq
Copy link
Contributor Author

allenwq commented Jul 7, 2015

@JuanitoFatas Thanks for the quick response !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allenwq @JuanitoFatas