Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed several compile bugs. #2439

Closed
wants to merge 1 commit into from
Closed

Fixed several compile bugs. #2439

wants to merge 1 commit into from

Conversation

trparky
Copy link
Contributor

@trparky trparky commented Mar 3, 2025 •
edited
Loading

Fixed several compile bugs.

jxy-s
jxy-s requested changes Mar 3, 2025
View reviewed changes
Copy link
Member

@jxy-s jxy-s left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to address these. But, I think @dmex should really address these since they were introduced by various recent changes of his. I expect he also has staged changes to address these already.

@jxy-s jxy-s requested a review from dmex March 3, 2025 18:03
@dmex
Copy link
Member

dmex commented Mar 4, 2025

Merged with 7f529f5

@dmex dmex closed this Mar 4, 2025
@dmex dmex removed the Blocked label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxy-s jxy-s jxy-s requested changes

@dmex dmex Awaiting requested review from dmex

Assignees

@dmex dmex

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trparky @dmex @jxy-s