fix(sdk): test execution in aws-cdk #7232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! 🎉 |
eladb
approved these changes
Jan 5, 2025
|
Thanks for contributing, @marciocadev! This PR will now be added to the merge queue, or immediately merged if |
|
Elad, could you please approve this PR first? I want to test the cloud.Service PR. |
|
Congrats! 🚀 This was released in Wing 0.85.40. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pull Request v0.79.13 changed the way the lambdas test ARNs are passed to the TestRunnerClient, unfortunately, it was not noticed that the target awscdk should also be changed. This change allowed the tests to be executed correctly.
Closes #7229
Checklist
pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.