Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): adding cloud.Service to awscdk #7230

Merged
merged 5 commits into from
Jan 5, 2025

Conversation

marciocadev
Copy link
Collaborator

@marciocadev marciocadev commented Jan 2, 2025

πŸ‘· WORK IN PROGRESS ... AGAIN πŸ—οΈ

Adding cloud.Service to AWS-CDK

Closes #7226

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

Copy link

github-actions bot commented Jan 2, 2025

Thanks for opening this pull request! πŸŽ‰
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping use over Discord.

Signed-off-by: monada-bot[bot] <[email protected]>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jan 2, 2025
@marciocadev marciocadev marked this pull request as ready for review January 4, 2025 23:06
@marciocadev marciocadev requested a review from a team as a code owner January 4, 2025 23:06
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@marciocadev marciocadev marked this pull request as draft January 5, 2025 11:13
@marciocadev marciocadev marked this pull request as ready for review January 5, 2025 20:43
@marciocadev marciocadev requested a review from eladb January 5, 2025 20:51
@marciocadev marciocadev removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jan 5, 2025
Copy link
Contributor

mergify bot commented Jan 5, 2025

Thanks for contributing, @marciocadev! This PR will now be added to the merge queue, or immediately merged if service-aws-cdk is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 332bd69 into winglang:main Jan 5, 2025
14 checks passed
@monadabot
Copy link
Contributor

Congrats! πŸš€ This was released in Wing 0.85.40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS CDK support for cloud.Service
3 participants