Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): comparison between mutable and immutable objects #3870

Merged
merged 11 commits into from
Aug 23, 2023

Conversation

marciocadev
Copy link
Collaborator

@marciocadev marciocadev commented Aug 17, 2023

Closes #2867

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@marciocadev marciocadev requested a review from a team as a code owner August 17, 2023 20:39
libs/wingc/src/type_check.rs Outdated Show resolved Hide resolved
libs/wingc/src/type_check.rs Outdated Show resolved Hide resolved
@marciocadev
Copy link
Collaborator Author

Thank you, @MarkMcCulloh . I basically just opened the PR, you're the one who did the heavy lifting. 😁

Copy link
Contributor

@MarkMcCulloh MarkMcCulloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

libs/wingc/src/type_check.rs Outdated Show resolved Hide resolved
libs/wingc/src/type_check.rs Outdated Show resolved Hide resolved
libs/wingc/src/type_check.rs Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2023

Thanks for contributing, @marciocadev! This PR will now be added to the merge queue, or immediately merged if marciocadev/comparison-mutable-immutable is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit fb3f024 into main Aug 23, 2023
@mergify mergify bot deleted the marciocadev/comparison-mutable-immutable branch August 23, 2023 19:39
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.25.39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison of Mutable and Immutable types is not possible
3 participants