Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): addfile() is a preflight method which adds file from absolute path #3801

Merged
merged 29 commits into from
Aug 21, 2023
Merged

feat(sdk): addfile() is a preflight method which adds file from absolute path #3801

merged 29 commits into from
Aug 21, 2023

Conversation

g3Bg2
Copy link
Contributor

@g3Bg2 g3Bg2 commented Aug 13, 2023

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@g3Bg2 g3Bg2 requested a review from a team as a code owner August 13, 2023 16:34
@g3Bg2 g3Bg2 changed the title feat(sdk): addfile() is a preflight method which adds file from absolute path. feat(sdk): addfile() is a preflight method which adds file from absolute path Aug 13, 2023
@eladb eladb changed the title feat(sdk): addfile() is a preflight method which adds file from absolute path feat(sdk): addfile() is a preflight method which adds file from absolute path Aug 13, 2023
tsuf239
tsuf239 suggested changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@tsuf239 tsuf239 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Really awesome 1st PR 🎉
Can you please add a test or two written in Wing to a new file in this folder: examples/tests/sdk_tests/bucket
It help us to keep stability between versions :)

libs/wingsdk/src/std/file.ts Outdated Show resolved Hide resolved
libs/wingsdk/src/std/file.ts Outdated Show resolved Hide resolved
libs/wingsdk/src/target-awscdk/bucket.ts Outdated Show resolved Hide resolved
libs/wingsdk/src/target-sim/bucket.ts Outdated Show resolved Hide resolved
libs/wingsdk/src/target-tf-aws/bucket.ts Outdated Show resolved Hide resolved
libs/wingsdk/src/target-tf-azure/bucket.ts Outdated Show resolved Hide resolved
libs/wingsdk/src/target-tf-gcp/bucket.ts Outdated Show resolved Hide resolved
libs/wingsdk/test/target-awscdk/bucket.test.ts Show resolved Hide resolved
@g3Bg2 g3Bg2 requested a review from tsuf239 August 15, 2023 15:07
tsuf239
tsuf239 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@tsuf239 tsuf239 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ✨
Just one comment is left before merging

libs/wingsdk/src/cloud/bucket.ts Show resolved Hide resolved
libs/wingsdk/src/target-sim/bucket.ts Outdated Show resolved Hide resolved
g3Bg2 and others added 2 commits August 17, 2023 14:15
@g3Bg2
Update bucket.ts
5ce490c 
Removed unused scope variable from target-sim/bucket.ts
@monadabot
chore: self mutation
a1c867f 
Signed-off-by: monada-bot[bot] <[email protected]>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 17, 2023
@tsuf239
Copy link
Contributor

tsuf239 commented Aug 20, 2023

pushed a fix for the test paths and missing entrypointDir, the tests should pass now :)

eladb
eladb reviewed Aug 20, 2023
View reviewed changes
libs/wingsdk/src/cloud/bucket.ts Outdated Show resolved Hide resolved
apps/jsii-docgen/LICENSE Show resolved Hide resolved
libs/wingsdk/src/cloud/bucket.ts Show resolved Hide resolved
libs/wingsdk/src/target-sim/bucket.ts Outdated Show resolved Hide resolved
@g3Bg2 g3Bg2 requested a review from eladb August 20, 2023 15:03
@tsuf239 tsuf239 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 21, 2023
@monadabot
chore: self mutation
2c16f1d 
Signed-off-by: monada-bot[bot] <[email protected]>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 21, 2023
@tsuf239
Copy link
Contributor

tsuf239 commented Aug 21, 2023

@MarkMcCulloh do you have any idea why does "@monadabot
chore: self mutation" keep adding those license files and changing the package.json?

@MarkMcCulloh MarkMcCulloh removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 21, 2023
@MarkMcCulloh
Copy link
Contributor

MarkMcCulloh commented Aug 21, 2023 •
edited
Loading

Looks like a change to projen slipped without updating the actual file. I say go ahead and keep whatever the self mutation does, my PR here #3913 fixes things.

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

Thanks for contributing, @0018akhil! This PR will now be added to the merge queue, or immediately merged if akhil-addfile is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Aug 21, 2023
@mergify
Merge of #3801
6eefc34
@mergify mergify bot mentioned this pull request Aug 21, 2023
Closed
10 tasks
@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

Thanks for contributing, @0018akhil! This PR will now be added to the merge queue, or immediately merged if akhil-addfile is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit ba6730e into winglang:main Aug 21, 2023
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.25.32.

@Chriscbr Chriscbr mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsuf239 tsuf239 tsuf239 approved these changes

@Chriscbr Chriscbr Chriscbr left review comments

@eladb eladb Awaiting requested review from eladb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@g3Bg2 @tsuf239 @MarkMcCulloh @monadabot @eladb @Chriscbr