Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): website has no url protocol on tf-aws #3757

Merged
merged 11 commits into from
Aug 20, 2023
Merged

Conversation

tsuf239
Copy link
Contributor

@tsuf239 tsuf239 commented Aug 9, 2023

fixes #3529

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 9, 2023
@eladb
Copy link
Contributor

eladb commented Aug 9, 2023

@tsuf239 please check the pull request guidelines for writing titles. The title for fix should reflect what's not working. In this case, it should be something like fix(sdk): fetch fails without url protocol. Or something like this.

libs/wingsdk/src/http/http.ts Outdated Show resolved Hide resolved
@tsuf239 tsuf239 changed the title fix(sdk): fixing fetch url when not specifying a protocol fix(sdk): website has no url protocol on tf-aws Aug 10, 2023
@tsuf239 tsuf239 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 10, 2023
@tsuf239 tsuf239 requested a review from eladb August 10, 2023 10:14
@tsuf239 tsuf239 marked this pull request as ready for review August 10, 2023 10:15
@tsuf239 tsuf239 requested a review from a team as a code owner August 10, 2023 10:15
libs/wingsdk/src/target-tf-aws/website.ts Outdated Show resolved Hide resolved
@tsuf239 tsuf239 requested a review from eladb August 13, 2023 08:20
Signed-off-by: monada-bot[bot] <[email protected]>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 13, 2023
@tsuf239 tsuf239 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 20, 2023

Thanks for contributing, @tsuf239! This PR will now be added to the merge queue, or immediately merged if tsuf/fixing-fetch is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Aug 20, 2023
@mergify mergify bot merged commit 977fa9e into main Aug 20, 2023
@mergify mergify bot deleted the tsuf/fixing-fetch branch August 20, 2023 15:30
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.25.29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website url failed to parse inflight test function
3 participants