-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk): update queue.push()
to use variadic parameter for messages
#3746
Conversation
a90d2ac
to
cd41a53
Compare
queue.push
to use variadic argument for messagesqueue.push
to use variadic parameter for messages
Signed-off-by: monada-bot[bot] <[email protected]>
Co-authored-by: Chris Rybicki <[email protected]>
3e42bf3
to
224e42f
Compare
@Chriscbr I was wondering if it wouldn't be better to preserve the |
@garysassano What would the pros and cons be? |
queue.push
to use variadic parameter for messagesqueue.push()
to use variadic parameter for messages
05a4459
to
1d6e741
Compare
1d6e741
to
4f36128
Compare
@Chriscbr Not many things come to my mind, but probably:
|
dd4eeb3
to
fc9dcd1
Compare
I think it's fine to just keep a single method for now. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
680a989
to
80f3ab1
Compare
Signed-off-by: monada-bot[bot] <[email protected]>
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Congrats! 🚀 This was released in Wing 0.25.18. |
Closes #2278
By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.