Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tf-gcp to the sdk spec tests gh workflow- to run on demand and after release #5236

Closed
1 of 2 tasks
tsuf239 opened this issue Dec 17, 2023 · 4 comments · Fixed by #6816
Closed
1 of 2 tasks

Adding tf-gcp to the sdk spec tests gh workflow- to run on demand and after release #5236

tsuf239 opened this issue Dec 17, 2023 · 4 comments · Fixed by #6816
Assignees
@tsuf239
Labels
✨ enhancement New feature or request ☁️ gcp Related to Google Cloud Platform support needs-discussion Further discussion is needed prior to impl 🎨 sdk SDK 🧪 testing

Comments

@tsuf239
Copy link
Contributor

tsuf239 commented Dec 17, 2023 •
edited
Loading

Use Case

Now when we have the test command set for tf-gcp, we'll start to get many PRs (hopefully 🤞 )

Proposed Solution

I started integrating it into our sdk-spec-tests gh action, and got to some problems, some I could fix:

  • getting the right identity-token
  • too many service accounts- we're currently creating 1 service account per cloud function- to encapsulate the permissions, but we cannot create too many of them at the same time, since we're surpassing the "per-minute" quota...
    we should either wait in between creations, or find another solution for the permissions

Implementation Notes

the working branch is tsuf/sdk-spec-test-gcp

Component

No response

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
  • If this issue is labeled needs-discussion, it means the spec has not been finalized yet. Please reach out on the #dev channel in the Wing Slack.
@tsuf239 tsuf239 added ✨ enhancement New feature or request needs-discussion Further discussion is needed prior to impl labels Dec 17, 2023
@tsuf239 tsuf239 self-assigned this Dec 17, 2023
@monadabot monadabot added this to Wing Dec 17, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New - not properly defined in Wing Dec 17, 2023
@staycoolcall911 staycoolcall911 moved this from 🆕 New - not properly defined to 🤝 Backlog - handoff to owners in Wing Dec 20, 2023
@staycoolcall911 staycoolcall911 added 🎨 sdk SDK 🧪 testing ☁️ gcp Related to Google Cloud Platform support labels Dec 20, 2023
@github-actions GitHub Actions
Copy link

Hi,

This issue hasn't seen activity in 60 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

@github-actions github-actions bot added the Stale label Feb 20, 2024
@tsuf239
Copy link
Contributor Author

tsuf239 commented Jun 2, 2024

the service account quota could be solved with #6381

@tsuf239
Copy link
Contributor Author

tsuf239 commented Jun 23, 2024

we could pass the first two, but now stuck with:
"Error 429: Maximum number of roles reached. Maximum is: 300"
which includes both active and soft-deleted roles. When you delete a custom role, it goes into a "soft delete" state for 7 days, during which it still counts towards your quota of 300 custom roles.

I believe we need to assign the permissions straight to the cloud function then, instead of creating a custom role.

@tsuf239 tsuf239 mentioned this issue Jul 1, 2024
Merged
5 tasks
@mergify mergify bot closed this as completed in #6816 Jul 11, 2024
mergify bot pushed a commit that referenced this issue Jul 11, 2024
@tsuf239
feat(repo): add tf-gcp to the sdk-spec-tests action (#6816)
831fb2d 
fixes: [#5236](#5236)
see the issue for more information about the changes

## Checklist

- [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [ ] Description explains motivation and solution
- [ ] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
@github-project-automation github-project-automation bot moved this from 🤝 Backlog - handoff to owners to ✅ Done in Wing Jul 11, 2024
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.77.5.

boyney123 pushed a commit that referenced this issue Jul 15, 2024
@tsuf239
feat(repo): add tf-gcp to the sdk-spec-tests action (#6816)
d973065 
fixes: [#5236](#5236)
see the issue for more information about the changes

## Checklist

- [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [ ] Description explains motivation and solution
- [ ] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsuf239 tsuf239

Labels
✨ enhancement New feature or request ☁️ gcp Related to Google Cloud Platform support needs-discussion Further discussion is needed prior to impl 🎨 sdk SDK 🧪 testing
Projects
Wing
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(repo): add tf-gcp to the sdk-spec-tests action winglang/wing
3 participants
@tsuf239 @staycoolcall911 @monadabot