Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"translate" passing tests to supported resources, methods and props #4644

Closed
Tracked by #4505
tsuf239 opened this issue Oct 23, 2023 · 2 comments · Fixed by #5243
Closed
Tracked by #4505

"translate" passing tests to supported resources, methods and props #4644

tsuf239 opened this issue Oct 23, 2023 · 2 comments · Fixed by #5243
Assignees
Labels
⌨️ cli CLI 🌧️ cloud-coverage Related to the cloud coverage project ✨ enhancement New feature or request

Comments

@tsuf239
Copy link
Contributor

tsuf239 commented Oct 23, 2023

No description provided.

@tsuf239 tsuf239 self-assigned this Oct 23, 2023
@monadabot monadabot added this to Wing Oct 23, 2023
@tsuf239 tsuf239 added the 🌧️ cloud-coverage Related to the cloud coverage project label Oct 23, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New - not properly defined in Wing Oct 23, 2023
@tsuf239 tsuf239 added ⌨️ cli CLI ✨ enhancement New feature or request labels Oct 23, 2023
@tsuf239 tsuf239 moved this from 🆕 New - not properly defined to 🏗 In progress in Wing Oct 23, 2023
@staycoolcall911 staycoolcall911 added this to the KubeCon23 milestone Oct 23, 2023
@tsuf239 tsuf239 moved this from 🏗 In progress to 👀 In review in Wing Dec 20, 2023
Copy link

github-actions bot commented Jan 6, 2024

Hi,

This issue hasn't seen activity in 60 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

@github-actions github-actions bot added the Stale label Jan 6, 2024
@mergify mergify bot closed this as completed in #5243 Jan 18, 2024
mergify bot pushed a commit that referenced this issue Jan 18, 2024
## Description
closes #4644 
As a part of the matrix automation process, we need to figure out what are the methods and properties that are used in each test. I came out with the following approach:
- collect the inflight methods from the `_addOnLift`
- collect the preflight methods and properties by adding a proxy to the Resource class
- save the collected methods list to a file in the output dir (currently, it may change in the future)

### Implemented by adding a new platform (@hasanaburayyan FYI)

Please let me know what you think :) 

TODO:
- [x] Add tests
- [ ] ~Change platform documentation (to reflect the change in the newInstance method)~
- [ ] Prefix "internal" prelight properties and methods with a "_"
 
## Checklist

- [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [ ] Description explains motivation and solution
- [ ] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Wing Jan 18, 2024
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.54.41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌨️ cli CLI 🌧️ cloud-coverage Related to the cloud coverage project ✨ enhancement New feature or request
Projects
Archived in project
3 participants