Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot submit PRs from forks #256

Closed
MarkMcCulloh opened this issue Oct 12, 2022 · 2 comments · Fixed by #1108
Closed

Cannot submit PRs from forks #256

MarkMcCulloh opened this issue Oct 12, 2022 · 2 comments · Fixed by #1108
Assignees
@MarkMcCulloh
Labels
🐛 bug Something isn't working

Comments

@MarkMcCulloh
Copy link
Contributor

PR builds should:

  • Trigger based on "pr target" changes
  • Build everything
  • Test what is needed based on changes
  • Support use in forks

"Releasable" builds should:

  • Trigger based on "push to main"
  • Build everything
  • Test everything
@staycoolcall911 staycoolcall911 changed the title Separate workflow for PR vs "releaseble" builds Separate workflow for PR vs "releasable" builds Nov 14, 2022
@MarkMcCulloh MarkMcCulloh changed the title Separate workflow for PR vs "releasable" builds Separate workflow for PR vs "releaseable" builds Nov 14, 2022
@staycoolcall911 staycoolcall911 moved this to 🆕 New - not properly defined in Wing Nov 20, 2022
@staycoolcall911 staycoolcall911 moved this from 🆕 New - not properly defined to 🤝 Backlog - handoff to owners in Wing Nov 27, 2022
@eladb eladb changed the title Separate workflow for PR vs "releaseable" builds Cannot submit PRs from forks Jan 5, 2023
@eladb eladb added the 🐛 bug Something isn't working label Jan 5, 2023
@eladb eladb mentioned this issue Jan 5, 2023
Merged
@Chriscbr Chriscbr pinned this issue Jan 7, 2023
@Chriscbr
Copy link
Contributor

Chriscbr commented Jan 7, 2023

Pinning this issue to improve visibility for anyone trying to contribute.

Right now we have a item in our short-term backlog to get our CI/CD workflows working on forks - until then, if you are someone looking to submit a pull request, please request access through https://www.winglang.io/ to get membership access to the repo, and then you can create a branch directly. Thanks!

@Chriscbr Chriscbr mentioned this issue Jan 7, 2023
Closed
@MarkMcCulloh MarkMcCulloh mentioned this issue Jan 10, 2023
Merged
MarkMcCulloh added a commit that referenced this issue Jan 10, 2023
@MarkMcCulloh
chore: alerting workflow triggered by check_run event (#1093)
690bc97 
The `build` workflow needs to be simplified/split-up in preparation for #256. The alert workflow doesn't need to run in forks, nor does it even need to run on push. This is one less thing to worry about in forks (check_run events should not be triggered by forks AFAIK)


*By submitting this pull request, I confirm that my contribution is made under the terms of the 
[Monada Contribution License](https://docs.winglang.io/terms-and-policies/contribution-license.html)*.
@MarkMcCulloh MarkMcCulloh self-assigned this Jan 10, 2023
@MarkMcCulloh MarkMcCulloh mentioned this issue Jan 11, 2023
Merged
eladb pushed a commit that referenced this issue Jan 11, 2023
@MarkMcCulloh
chore: fork-based workflows (#1108)
fd9f0ef 
Because the workflows won't run until merged to main. My fork at
https://github.com/MarkMcCulloh/wing has example of the workflow running
on a fork (AKA a place that doesn't have access to all the secrets). I
propose an admin force merges this PR.

### What's going on here:
- build workflow now uses pull_request_target in addition to push (for
`main` only)
- Ensured PROJEN_GITHUB_TOKEN is only used in places that would have
access to it (pushes to main on our repo)
- GITHUB_TOKEN should have all the permissions needed to do what we need
in forks
- Simplified the self-mutation logic and verified it works in a fork.
Eventually, the self mutator won't be specific to wingsdk :)

Fixes #256

*By submitting this pull request, I confirm that my contribution is made
under the terms of the
[Monada Contribution
License](https://docs.winglang.io/terms-and-policies/contribution-license.html)*.
@github-project-automation github-project-automation bot moved this from 🤝 Backlog - handoff to owners to ✅ Done in Wing Jan 11, 2023
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.4.76.

@eladb eladb unpinned this issue Jan 12, 2023
skyrpex added a commit that referenced this issue Jun 21, 2023
@polamoros @skyrpex
feat: add Counter resource (#256)
9fca31a 
Fixes #244

Co-authored-by: Cristian Pallarés <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkMcCulloh MarkMcCulloh

Labels
🐛 bug Something isn't working
Projects
Wing
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fork-based workflows winglang/wing
4 participants
@eladb @MarkMcCulloh @Chriscbr @monadabot