Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds timer feature with pause/resume and unanswered filter #190

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

chyke007
Copy link
Contributor

@chyke007 chyke007 commented Jan 4, 2024

Adds timer feature with

  • Timer Support in HH:MM:SS
  • Displays total time taken after quiz completion
  • Completes quiz and submits once time runs out
  • Support Pause/Resume Timer
  • Shows unanswered questions
  • Filter unanswered questions

Sample image:

Screen Shot 2024-01-04 at 1 59 01 AM Screen Shot 2024-01-04 at 1 59 49 AM Screen Shot 2024-01-04 at 1 58 50 AM

Copy link
Owner

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • prefer to put the explanation under the tags. now it will break the layout.
image

Expected:

image

  • pause button not quite aligned with Time Remaining / Question

image

  • we need to add validation for timer and allowPauseTimer in Quiz.jsx. Check if it is valid number and boolean respectively.

src/lib/Core.jsx Outdated Show resolved Hide resolved
src/lib/Core.jsx Outdated Show resolved Hide resolved
src/lib/Core.jsx Outdated Show resolved Hide resolved
src/lib/Core.jsx Outdated Show resolved Hide resolved
src/lib/Core.jsx Outdated Show resolved Hide resolved
src/lib/Core.jsx Outdated Show resolved Hide resolved
src/lib/Core.jsx Show resolved Hide resolved
src/lib/Core.jsx Outdated Show resolved Hide resolved
@chyke007 chyke007 requested a review from wingkwong January 4, 2024 14:13
@wingkwong wingkwong merged commit f899112 into wingkwong:develop Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants