Skip to content

Commit

Permalink
fix(server): unconstify data members
Browse files Browse the repository at this point in the history
Clang-tidy 16 implements a check for C++ Core Guidelines C.12. [1] That
requires data members to not be const.

[1] https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-constref
  • Loading branch information
romangg committed Sep 10, 2023
1 parent 77cbb96 commit 3d1c8f5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion server/plasma_virtual_desktop.h
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class WRAPLANDSERVER_EXPORT PlasmaVirtualDesktop : public QObject
friend class PlasmaVirtualDesktopManager;

class Private;
const std::unique_ptr<Private> d_ptr;
std::unique_ptr<Private> d_ptr;
};

}
2 changes: 1 addition & 1 deletion server/plasma_window.h
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ class WRAPLANDSERVER_EXPORT PlasmaWindow : public QObject
explicit PlasmaWindow(PlasmaWindowManager* manager);

class Private;
const std::unique_ptr<Private> d_ptr;
std::unique_ptr<Private> d_ptr;
};

}
Expand Down

0 comments on commit 3d1c8f5

Please sign in to comment.