feat: assign top-left screen corner to overview by default

winft · Feb 24, 2024 · bf77283 · bf77283
1 parent 856927f
commit bf77283
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/kcms/screenedges/kwinscreenedgesettings.kcfg b/kcms/screenedges/kwinscreenedgesettings.kcfg
@@ -59,7 +59,7 @@ SPDX-License-Identifier: GPL-2.0-or-later
     </group>
     <group name="Effect-windowview">
         <entry key="BorderActivateAll" type="IntList">
-            <default>int(como::win::electric_border::top_left)</default>
+            <default>int(como::win::electric_border::none)</default>
         </entry>
         <entry name="BorderActivatePresentWindows" key="BorderActivate" type="IntList">
             <default>int(como::win::electric_border::none)</default>
@@ -84,9 +84,9 @@ SPDX-License-Identifier: GPL-2.0-or-later
             <default>int(como::win::electric_border::none)</default>
         </entry>
     </group>
-    <group name="Effect-Overview">
+    <group name="Effect-overview">
         <entry name="BorderActivateOverview" key="BorderActivate" type="IntList">
-            <default>int(como::win::electric_border::none)</default>
+            <default>int(como::win::electric_border::top_left)</default>
         </entry>
     </group>
     <group name="TabBox">

diff --git a/kcms/screenedges/main.cpp b/kcms/screenedges/main.cpp
@@ -108,8 +108,11 @@ void KWinScreenEdgesConfig::save()
     // and reconfigure the effects
     OrgKdeKwinEffectsInterface interface(
         QStringLiteral("org.kde.KWin"), QStringLiteral("/Effects"), QDBusConnection::sessionBus());
+
+    interface.reconfigureEffect(QStringLiteral("overview"));
     interface.reconfigureEffect(QStringLiteral("windowview"));
     interface.reconfigureEffect(QStringLiteral("cube"));
+
     for (auto const& effectId : qAsConst(m_effects)) {
         interface.reconfigureEffect(effectId);
     }
@@ -172,6 +175,7 @@ void KWinScreenEdgesConfig::monitorInit()
     m_form->monitorAddItem(i18n("%1 - Cube", cubeName));
     m_form->monitorAddItem(i18n("%1 - Cylinder", cubeName));
     m_form->monitorAddItem(i18n("%1 - Sphere", cubeName));
+    m_form->monitorAddItem(i18n("Overview"));
 
     m_form->monitorAddItem(i18n("Toggle window switching"));
     m_form->monitorAddItem(i18n("Toggle alternative window switching"));
@@ -256,6 +260,9 @@ void KWinScreenEdgesConfig::monitorLoadSettings()
     // PresentWindows BorderActivateClass
     m_form->monitorChangeEdge(m_data->settings()->borderActivateClass(), PresentWindowsClass);
 
+    // Overview
+    m_form->monitorChangeEdge(m_data->settings()->borderActivateOverview(), Overview);
+
     // Desktop Cube
     m_form->monitorChangeEdge(m_data->settings()->borderActivateCube(), Cube);
     m_form->monitorChangeEdge(m_data->settings()->borderActivateCylinder(), Cylinder);
@@ -322,6 +329,10 @@ void KWinScreenEdgesConfig::monitorLoadDefaultSettings()
     m_form->monitorChangeDefaultEdge(m_data->settings()->defaultBorderActivateClassValue(),
                                      PresentWindowsClass);
 
+    // Overview
+    m_form->monitorChangeDefaultEdge(m_data->settings()->defaultBorderActivateOverviewValue(),
+                                     Overview);
+
     // Desktop Cube
     m_form->monitorChangeDefaultEdge(m_data->settings()->defaultBorderActivateCubeValue(), Cube);
     m_form->monitorChangeDefaultEdge(m_data->settings()->defaultBorderActivateCylinderValue(),
@@ -367,6 +378,9 @@ void KWinScreenEdgesConfig::monitorSaveSettings()
     m_data->settings()->setBorderActivateClass(
         m_form->monitorCheckEffectHasEdgeInt(PresentWindowsClass));
 
+    // Overview
+    m_data->settings()->setBorderActivateOverview(m_form->monitorCheckEffectHasEdgeInt(Overview));
+
     // Desktop Cube
     m_data->settings()->setBorderActivateCube(m_form->monitorCheckEffectHasEdgeInt(Cube));
     m_data->settings()->setBorderActivateCylinder(m_form->monitorCheckEffectHasEdgeInt(Cylinder));
@@ -403,6 +417,9 @@ void KWinScreenEdgesConfig::monitorShowEvent()
     m_form->monitorItemSetEnabled(PresentWindowsCurrent, enabled);
     m_form->monitorItemSetEnabled(PresentWindowsAll, enabled);
 
+    // Overview
+    m_form->monitorItemSetEnabled(Overview, config.readEntry("overviewEnabled", true));
+
     // Desktop Cube
     enabled = config.readEntry("cube", true);
     m_form->monitorItemSetEnabled(Cube, enabled);

diff --git a/kcms/screenedges/main.h b/kcms/screenedges/main.h
@@ -50,6 +50,7 @@ public Q_SLOTS:
         Cube,
         Cylinder,
         Sphere,
+        Overview,
         TabBox,
         TabBoxAlternative,
         EffectCount