Update windspots.py #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New API from Windspots.com URL explore API : https://api.windspots.org/explorer/#/mobile Don't know when the URL https://api.windspots.com/windmobile/stationinfo will be decommissioned. proactively changed the mapping Need to be tested specially the mapping on the stations details -> https//api.windspots.org/mobile/stationdata?station={windspots_id}
ysavary
requested changes
Mar 15, 2022
| timeout=(self.connect_timeout, self.read_timeout), | ||
| verify=False, | ||
| ) | ||
|
|
||
| for windspots_station in result.json()["stationInfo"]: | ||
| station_id = None | ||
| try: | ||
| windspots_id = windspots_station["winId"][10:] | ||
| windspots_id = windspots_station["stationName"][10:] |
There was a problem hiding this comment.
Removing the 1st 10 chars is returning an invalid id
| @@ -51,13 +51,13 @@ def process_data(self): | |||
| raise ProviderException("Action=Data return invalid json response") | |||
|
|
|||
| try: | |||
| key = arrow.get(windspots_measure["@lastUpdate"], "YYYY-M-DTHH:mm:ssZ").int_timestamp | |||
| key = arrow.get(windspots_measure["lastUpdate"], "YYYY-M-DTHH:mm:ssZ").int_timestamp | |||
There was a problem hiding this comment.
lastUpdate is not existing any more with this new API
| @@ -51,13 +51,13 @@ def process_data(self): | |||
| raise ProviderException("Action=Data return invalid json response") | |||
|
|
|||
| try: | |||
| key = arrow.get(windspots_measure["@lastUpdate"], "YYYY-M-DTHH:mm:ssZ").int_timestamp | |||
| key = arrow.get(windspots_measure["lastUpdate"], "YYYY-M-DTHH:mm:ssZ").int_timestamp | |||
There was a problem hiding this comment.
lastUpdate is not existing any more with this new API
|
The linter failed. Please format your code with black: https://github.com/winds-mobi/winds-mobi-providers/blob/main/README.md#checking-the-code-style |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New API from Windspots.com
URL explore API : https://api.windspots.org/explorer/#/mobile
Don't know when the URL https://api.windspots.com/windmobile/stationinfo will be decommissioned.
proactively changed the mapping
Need to be tested specially the mapping on the stations details -> https//api.windspots.org/mobile/stationdata?station={windspots_id}