-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initial support for Termius (fixes #864) #902
Conversation
The CI failed, so I submitted this bug report to Termius' Customer Support page: Hey, I am a licensed Termius user, and submitted a GitHub PR to the deb-get project to add Termius at https://github.com//pull/902 Unfortunately, Termius failed to install, with the error:
The Is the issue fixable on my end, or does the .deb file need to be repackaged? Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to match the installed app exactly or remove
will not work. s/termius/termius-app/ in manifest and rename the package definition file to termius-app
They really need to fix their dependency. The CI doesn't install a desktop into the test environment, hence the lack of We need to think about improving the CI testing on several fronts. I'll add this to the issues list. If you rename the package file to match the application (termius-app) I see no need to wait for upstream to improve their packaging before merging this, but that would be the correct thing to do. Thanks for your contribution. |
@philclifford Done. Thanks for your help. Still getting up to speed here. |
First submission so feedback appreciated.