-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated openrgb URLs #1059
Conversation
The first URL at https://openrgb.org/releases.html is https://openrgb.org/releases/release_0.9/openrgb_0.9_amd64_buster_b5f46e3.deb hence we need xdigit, not digit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is close but for me gives multiple results (the cases need to get one latest URL I think)
However on 22.04 I'm still getting into a broken package/dependency state so maybe there's more to it than just head -1
...
manually trying 0.9 on 22.04
aha : jammy should get bookworm! - yes sorted Please |
btw See my prior PR #1047 has the head -1 and bookworm fix (with alnum not xdigit as I didn't know for sure xdigit is right ;-) ), but please fix yours so it passes the check and I can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The first URL at
https://openrgb.org/releases.html
is
https://openrgb.org/releases/release_0.9/openrgb_0.9_amd64_buster_b5f46e3.deb
hence we need xdigit, not digit.
Edit:
closes #1047
fixes #1046