Security improvements #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @nepella Thanks for your contribution. Could you please run This will make the workflow pass. |
This will cause cache cookies to be invalidated when Traefik is restarted and won't work well where Traefik is clustered but is still better than shipping with an insecure value. Also, this is the HMAC key, not an encryption key. See the documentation for 'securecookie.New'.
Previously, CacheTimeout only affected the expiration time sent to the client; the code treated cookies as valid for 30 days.
|
My bad; I forgot to run |
|
Available in v0.1.10 release. |
|
Thanks much for getting this merged so quickly and for writing this plugin. I'd been using the Nginx-ldap-auth proof-of-concept with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See commit messages.)