fixed tcp_mem resource leak when sending 304 #153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our server's kernel would unexpectedly report
after a while, while the RAM itself was fine.
After a bit of digging, and a process of elimination of what had changed over the past few days, we suspected a program must be keeping TCP connections open, thus leaking tcp_mem. We tracked it down to being this line, and we have been running a container with this fix in production all day, without any significant raises in tcp_mem allocation (monitoring /proc/net/sockstat).