Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed tcp_mem resource leak when sending 304 #153

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

Micr0mega
Copy link

Our server's kernel would unexpectedly report

TCP: out of memory -- consider tuning tcp_mem

after a while, while the RAM itself was fine.
After a bit of digging, and a process of elimination of what had changed over the past few days, we suspected a program must be keeping TCP connections open, thus leaking tcp_mem. We tracked it down to being this line, and we have been running a container with this fix in production all day, without any significant raises in tcp_mem allocation (monitoring /proc/net/sockstat).

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@Micr0mega
Copy link
Author

@googlebot please try again

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@willnorris
Copy link
Owner

ooh, good catch. Thanks for the patch!

@willnorris willnorris merged commit 74c16f5 into willnorris:master Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants