Connection status client change #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamsyang-work
force-pushed
the
connection-status-client-change
branch
4 times, most recently
from
fb81c6f to
dcb2b26
Compare
'addConnectionStatusListener' changed to 'activate' 'removeConnectionStatusListener' changed to 'deactivate' This is more accurate. Signed-off-by: Will Yang <[email protected]>
williamsyang-work
force-pushed
the
connection-status-client-change
branch
from
b77b117 to
7c76c3c
Compare
Adds methods to add and remove functions that are executed when the server status is updated. Signed-off-by: Will Yang <[email protected]>
williamsyang-work
force-pushed
the
connection-status-client-change
branch
from
7c76c3c to
0cd602e
Compare
Removes direct DOM manipulation from TraceExplorerServerStatusWidget. Refactors it to use the server status change event listeners and change what is rendered through Theia ReactWidget's component lifecycle. Signed-off-by: Will Yang <[email protected]>
Check the server status every update in the trace-explorer-widget. This ensures that the 'Open Trace' placeholder widget is displayed when the server is offline, not just when there are no opened traces. Signed-off-by: Will Yang <[email protected]>
williamsyang-work
force-pushed
the
connection-status-client-change
branch
from
0cd602e to
93bedc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing.