feat(registry): add nxls #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lua/mason-registry/nxls/init.lua
Outdated
|
|
||
| return Pkg.new { | ||
| name = "nxls", | ||
| desc = [[A language server that utilizes the json-languageservice to provide code completion and more, for Nx workspaces.]], |
There was a problem hiding this comment.
(I see this description is taken directly from their README). This is a bit confusing to me, does it depend on json-languageservice somehow? I'm assuming it bundles everything it needs in the npm package, and so this level of description might be a bit excessive and confusing. What about
Suggested change
| desc = [[A language server that utilizes the json-languageservice to provide code completion and more, for Nx workspaces.]], | |
| desc = [[A language server that provides code completion and more for Nx workspaces.]], |
There was a problem hiding this comment.
Yes, you'r right. It does bundle vscode-json-languageservice, so mentioning it is unnecessary. I use your suggestion.
There was a problem hiding this comment.
Cool, thanks for confirming!
This was referenced Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #584