replace toSorted with sort equivalent (not in-place) #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @wille 👋
I love what you've been working on here and have been trying to integrate it into a Vite project I'm working on. One of the first things I noted was a lack of support for Node versions pre Node v20 (I am personally using Node 18), due to the use of
toSorted
. I've proposed a small change to getsort
on an array spread - LMK what you think!An aside
I noticed that you've been struggling with FOUC on dev and I know Remix were having a similar issue when they migrated to Vite. From this talk at Vitecon (https://youtu.be/mWK3Y_1kmaM?t=29878&feature=shared) it looks like they were able to get around that in a clean way. If you're interested I think the PR is remix-run/remix#8076.
I'm keen to explore features like partial hydration, is that something you'd be open to having in the library?