This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
set home variable on npm command #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if Puppet::Util::Package.versioncmp(Puppet.version, '3.0') >= 0 | ||
| has_command(:npm, '/usr/local/node/node-default/bin/npm') do | ||
| is_optional | ||
| environment :HOME => "/root" |
There was a problem hiding this comment.
Why hardcoding this directory BTW? I mean, is it always true that this directory is the home dir?
There was a problem hiding this comment.
I tried to remove
commands :npm => '/usr/local/node/node-default/bin/npm'and use
has_command(:npm, 'npm') but that raised an error … npm command not found.
Hm.
There was a problem hiding this comment.
Sorry, I was talking about the /root dir. The other one is correct, and the error you got is not unexpected.
There was a problem hiding this comment.
Oh. Yepp. No this is not always the home dir. I have only tested this for global package installations( npm install -g), where the home dir is required but not really used, I guess?
willdurand
added a commit
that referenced
this pull request
Jun 25, 2014
…-on-node-gyp set home variable on npm command
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50
Borrowed from voxpupuli/puppet-nodejs#59