[WFCORE-7012][WFCORE-7013] Fix ServerEnvironmentTestCase and ignore when server is running in default stability level #6205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Case#testAliasNotWorkingInDefaultStability Jira issue: https://issues.redhat.com/browse/WFCORE-7012
|
Hello @michpetrov , could you review this? thanks |
yersan
commented
Sep 27, 2024
| @@ -104,6 +109,7 @@ public void testAliasFunctionality() throws IOException { | |||
|
|
|||
| // default stability = COMMUNITY | |||
| ProductConfig productConfig = ProductConfig.fromFilesystemSlot(null, "", props); | |||
| Assume.assumeTrue(Stability.COMMUNITY.enables(productConfig.getDefaultStability())); | |||
There was a problem hiding this comment.
Ups, this should be equals not enables
… when server stability is default Jira issue: https://issues.redhat.com/browse/WFCORE-7013
yersan
force-pushed
the
WFCORE-7012-WFCORE-7013
branch
from
78652de to
375c463
Compare
yersan
added
the
ready-for-merge
|
Thanks @michpetrov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issues:
https://issues.redhat.com/browse/WFCORE-7012
https://issues.redhat.com/browse/WFCORE-7013